Project

General

Profile

Defect #139

typo in TraverseEventGenerator

Added by Michele Vivoda over 11 years ago. Updated over 11 years ago.

Status:
Fixed
Priority:
medium
Assignee:
Michele Vivoda
Category:
MarkReader
Target version:
sqs-reader - MarkReader2.1
Start date:
2012-05-08
Due date:
% Done:

100%

Estimated time:

Description

While developing an xml exporter I noticed the sequence of events was wrong, then I found this typo in method #traverseRow:

if (prevPageIndex == -1) {

should be

if (prevPageIndex != -1) {

BTW in cases of little changes like this, what you think, should I make a pull request or is better to just report like this ?

History

#1

Updated by Hiroya Kubo over 11 years ago

  • Status changed from Assigned to Fixed
  • Assignee set to Michele Vivoda
  • % Done changed from 50 to 100

Thanks Michele.

BTW in cases of little changes like this, what you think, should I make a pull request or is better to just report like this ?

It depends... You may do it any way you like.

I really appreciate bug fixes, refactoring and modification to use proper naming convention. Even drastic changes are welcome.

#2

Updated by Michele Vivoda over 11 years ago

You are welcome Hiroya,
ok, I will choose case by case
of course proper naming convention do you have any special or specified rule ?

perhaps also how the source is formatted should be specified, may be it already is, I don't know, it would be nice if the eclipse project would be specifying this details so that I can do ctrl+shift+f to format, I think now uses the user default formatting.

For example I use by default this format:

void method() {
if (..) {
}

}

I think you use

void method() {
if (..) {
}
}

#3

Updated by Michele Vivoda over 11 years ago

;-) the wiki formatted in the same way the methods..however I use a different default formatting than yours...

Also available in: Atom PDF